update formatter to handle record closing braces correctly#8106
Merged
mbien merged 1 commit intoapache:masterfrom Jan 5, 2025
Merged
update formatter to handle record closing braces correctly#8106mbien merged 1 commit intoapache:masterfrom
mbien merged 1 commit intoapache:masterfrom
Conversation
…ition - adds tests to show the error - adds inner and outer record in ui template text for setting java format spaces - solves the error by moving spaces(cs.spaceWithinMethodDeclParens() ? 1 : 0, true); to the correct place. Co-authored-by: Michael Bien <mbien42@gmail.com>
mbien
added
Java
matthiasblaesing
approved these changes
Jan 3, 2025
Contributor
matthiasblaesing
left a comment
matthiasblaesing
left a comment
There was a problem hiding this comment.
The change from @homberghp makes sense and the new test and the existing still working record formatting test indicate that this is a safe change.
I also agree that it is more in line with the rest of the module that the test is integrated into FormatingTest.
@homberghp @mbien thank you both.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
alternative to #8101 contributed by @homberghp,
rebased and moves the new regression test to
FormattingTest.spaces(cs.spaceWithinMethodDeclParens() ? 1 : 0, true);to the correct place.fixes #7043